OSDN Git Service

drm/vc4: hdmi: Use reg-names to retrieve the HDMI audio registers
authorDave Stevenson <dave.stevenson@raspberrypi.com>
Thu, 3 Sep 2020 08:01:37 +0000 (10:01 +0200)
committerMaxime Ripard <maxime@cerno.tech>
Mon, 7 Sep 2020 16:14:53 +0000 (18:14 +0200)
The register range used for audio setup in the previous generations of
SoC were always the second range in the device tree. However, now that
the BCM2711 has way more register ranges, it makes sense to retrieve it
by names for it, while preserving the id-based lookup as a fallback.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Tested-by: Chanwoo Choi <cw00.choi@samsung.com>
Tested-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
Link: https://patchwork.freedesktop.org/patch/msgid/a1ba5605fe1006a1ead5262ef3d66ea5d0750381.1599120059.git-series.maxime@cerno.tech
drivers/gpu/drm/vc4/vc4_hdmi.c

index 487c04d..53c3b5a 100644 (file)
@@ -953,6 +953,7 @@ static int vc4_hdmi_audio_init(struct vc4_hdmi *vc4_hdmi)
        struct snd_soc_card *card = &vc4_hdmi->audio.card;
        struct device *dev = &vc4_hdmi->pdev->dev;
        const __be32 *addr;
+       int index;
        int ret;
 
        if (!of_find_property(dev->of_node, "dmas", NULL)) {
@@ -973,7 +974,13 @@ static int vc4_hdmi_audio_init(struct vc4_hdmi *vc4_hdmi)
         * for DMA transfers.
         * This VC/MMU should probably be exposed to avoid this kind of hacks.
         */
-       addr = of_get_address(dev->of_node, 1, NULL, NULL);
+       index = of_property_match_string(dev->of_node, "reg-names", "hd");
+       /* Before BCM2711, we don't have a named register range */
+       if (index < 0)
+               index = 1;
+
+       addr = of_get_address(dev->of_node, index, NULL, NULL);
+
        vc4_hdmi->audio.dma_data.addr = be32_to_cpup(addr) + mai_data->offset;
        vc4_hdmi->audio.dma_data.addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
        vc4_hdmi->audio.dma_data.maxburst = 2;