OSDN Git Service

staging: android: ion: tegra: Use devm_kcalloc instead of devm_kzalloc
authorAmitoj Kaur Chawla <amitoj1606@gmail.com>
Thu, 25 Feb 2016 13:55:04 +0000 (19:25 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 12 Mar 2016 06:09:09 +0000 (22:09 -0800)
Replace devm_kzalloc with devm_kcalloc to ensure there are no integer
overflows from the multiplication of a number * sizeof.

The following Coccinelle semantic patch was used to make this change:
//<smpl>
@@
expression dev,E1,E3;
type T;
@@
- devm_kzalloc(dev,E1*sizeof(T),E3)
+ devm_kcalloc(dev,E1,sizeof(T),E3)
//</smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/android/ion/tegra/tegra_ion.c

index 4d3c516..8828524 100644 (file)
@@ -33,9 +33,8 @@ static int tegra_ion_probe(struct platform_device *pdev)
 
        num_heaps = pdata->nr;
 
-       heaps = devm_kzalloc(&pdev->dev,
-                            sizeof(struct ion_heap *) * pdata->nr,
-                            GFP_KERNEL);
+       heaps = devm_kcalloc(&pdev->dev, pdata->nr,
+                            sizeof(struct ion_heap *), GFP_KERNEL);
 
        idev = ion_device_create(NULL);
        if (IS_ERR_OR_NULL(idev))