OSDN Git Service

drm/sun4i: backend: Move the coord function in the shared part
authorMaxime Ripard <maxime.ripard@free-electrons.com>
Sun, 17 Dec 2017 16:34:26 +0000 (17:34 +0100)
committerMaxime Ripard <maxime.ripard@free-electrons.com>
Mon, 29 Jan 2018 13:02:38 +0000 (14:02 +0100)
The function supposed to update a plane's coordinates is called in both
branches of our function. Let's move it out the if statement.

Acked-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Link: https://patchwork.freedesktop.org/patch/msgid/2cd57bcf13652109da7bd5bbe12fa1d29429f02f.1516617243.git-series.maxime.ripard@free-electrons.com
drivers/gpu/drm/sun4i/sun4i_layer.c

index f03da16..c448cb6 100644 (file)
@@ -106,14 +106,13 @@ static void sun4i_backend_layer_atomic_update(struct drm_plane *plane,
                                              DRM_FORMAT_ARGB8888);
                sun4i_backend_update_layer_frontend(backend, layer->id,
                                                    DRM_FORMAT_ARGB8888);
-               sun4i_backend_update_layer_coord(backend, layer->id, plane);
                sun4i_frontend_enable(frontend);
        } else {
-               sun4i_backend_update_layer_coord(backend, layer->id, plane);
                sun4i_backend_update_layer_formats(backend, layer->id, plane);
                sun4i_backend_update_layer_buffer(backend, layer->id, plane);
        }
 
+       sun4i_backend_update_layer_coord(backend, layer->id, plane);
        sun4i_backend_layer_enable(backend, layer->id, true);
 }