OSDN Git Service

net: mvneta: do not explicitly set the carrier state in open
authorAntoine Tenart <antoine.tenart@bootlin.com>
Wed, 19 Sep 2018 09:39:33 +0000 (11:39 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 20 Sep 2018 04:15:02 +0000 (21:15 -0700)
This patch removes the explicit call to netif_carrier_off() in
mvneta_open() as this is already handled in phylink_start().

Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/mvneta.c

index fe3edb3..89ed1df 100644 (file)
@@ -3791,9 +3791,6 @@ static int mvneta_open(struct net_device *dev)
                        goto err_free_online_hp;
        }
 
-       /* In default link is down */
-       netif_carrier_off(pp->dev);
-
        ret = mvneta_mdio_probe(pp);
        if (ret < 0) {
                netdev_err(dev, "cannot probe MDIO bus\n");