OSDN Git Service

nvmet: replace kstrndup() with kmemdup_nul()
authorChen Zhou <chenzhou10@huawei.com>
Fri, 8 May 2020 11:59:06 +0000 (19:59 +0800)
committerChristoph Hellwig <hch@lst.de>
Wed, 27 May 2020 05:12:36 +0000 (07:12 +0200)
It is more efficient to use kmemdup_nul() if the size is known exactly.

The doc in kernel:
"Note: Use kmemdup_nul() instead if the size is known exactly."

Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/target/configfs.c

index ae8fb44..19bd5e1 100644 (file)
@@ -324,7 +324,7 @@ static ssize_t nvmet_ns_device_path_store(struct config_item *item,
 
        kfree(ns->device_path);
        ret = -ENOMEM;
-       ns->device_path = kstrndup(page, len, GFP_KERNEL);
+       ns->device_path = kmemdup_nul(page, len, GFP_KERNEL);
        if (!ns->device_path)
                goto out_unlock;
 
@@ -960,7 +960,7 @@ static ssize_t nvmet_subsys_attr_model_store(struct config_item *item,
                        return -EINVAL;
        }
 
-       new_model_number = kstrndup(page, len, GFP_KERNEL);
+       new_model_number = kmemdup_nul(page, len, GFP_KERNEL);
        if (!new_model_number)
                return -ENOMEM;