OSDN Git Service

net: ethernet: ixgbe: check the return value of ixgbe_mii_bus_init()
authorBartosz Golaszewski <bgolaszewski@baylibre.com>
Mon, 29 Jun 2020 12:03:37 +0000 (14:03 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 30 Jun 2020 22:57:34 +0000 (15:57 -0700)
This function may fail. Check its return value and propagate the error
code.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

index 254486e..fabdca9 100644 (file)
@@ -11173,10 +11173,14 @@ skip_sriov:
                        IXGBE_LINK_SPEED_10GB_FULL | IXGBE_LINK_SPEED_1GB_FULL,
                        true);
 
-       ixgbe_mii_bus_init(hw);
+       err = ixgbe_mii_bus_init(hw);
+       if (err)
+               goto err_netdev;
 
        return 0;
 
+err_netdev:
+       unregister_netdev(netdev);
 err_register:
        ixgbe_release_hw_control(adapter);
        ixgbe_clear_interrupt_scheme(adapter);