OSDN Git Service

platform/surface: aggregator_hub: Use target-ID enum instead of hard-coding values
authorMaximilian Luz <luzmaximilian@gmail.com>
Fri, 2 Dec 2022 22:33:22 +0000 (23:33 +0100)
committerHans de Goede <hdegoede@redhat.com>
Thu, 2 Feb 2023 21:48:20 +0000 (22:48 +0100)
Instead of hard-coding the target ID, use the respective enum
ssam_ssh_tid value.

Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
Link: https://lore.kernel.org/r/20221202223327.690880-5-luzmaximilian@gmail.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/surface/surface_aggregator_hub.c

index 4306151..62f27cd 100644 (file)
@@ -214,7 +214,7 @@ static void ssam_hub_remove(struct ssam_device *sdev)
 
 SSAM_DEFINE_SYNC_REQUEST_R(ssam_bas_query_opmode, u8, {
        .target_category = SSAM_SSH_TC_BAS,
-       .target_id       = 0x01,
+       .target_id       = SSAM_SSH_TID_SAM,
        .command_id      = 0x0d,
        .instance_id     = 0x00,
 });
@@ -292,7 +292,7 @@ static const struct ssam_hub_desc base_hub = {
 
 SSAM_DEFINE_SYNC_REQUEST_R(__ssam_kip_query_state, u8, {
        .target_category = SSAM_SSH_TC_KIP,
-       .target_id       = 0x01,
+       .target_id       = SSAM_SSH_TID_SAM,
        .command_id      = 0x2c,
        .instance_id     = 0x00,
 });