OSDN Git Service

drm: i915: sysfs: constify attribute_group structures.
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Mon, 3 Jul 2017 11:08:25 +0000 (16:38 +0530)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 6 Jul 2017 09:27:32 +0000 (11:27 +0200)
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.

File size before:
   text    data     bss     dec     hex filename
   4028    1088       0    5116    13fc drivers/gpu/drm/i915/i915_sysfs.o

File size After adding 'const':
   text    data     bss     dec     hex filename
   4196     928       0    5124    1404 drivers/gpu/drm/i915/i915_sysfs.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/13b5c875e677c10e6257be4fac31b2b6c77a494f.1499079914.git.arvind.yadav.cs@gmail.com
drivers/gpu/drm/i915/i915_sysfs.c

index 3a48106..3736c9f 100644 (file)
@@ -96,7 +96,7 @@ static struct attribute *rc6_attrs[] = {
        NULL
 };
 
-static struct attribute_group rc6_attr_group = {
+static const struct attribute_group rc6_attr_group = {
        .name = power_group_name,
        .attrs =  rc6_attrs
 };
@@ -107,7 +107,7 @@ static struct attribute *rc6p_attrs[] = {
        NULL
 };
 
-static struct attribute_group rc6p_attr_group = {
+static const struct attribute_group rc6p_attr_group = {
        .name = power_group_name,
        .attrs =  rc6p_attrs
 };
@@ -117,7 +117,7 @@ static struct attribute *media_rc6_attrs[] = {
        NULL
 };
 
-static struct attribute_group media_rc6_attr_group = {
+static const struct attribute_group media_rc6_attr_group = {
        .name = power_group_name,
        .attrs =  media_rc6_attrs
 };