OSDN Git Service

phy: qcom-qmp: switch to explicit reset helpers
authorJohan Hovold <johan+linaro@kernel.org>
Wed, 27 Apr 2022 06:32:43 +0000 (08:32 +0200)
committerVinod Koul <vkoul@kernel.org>
Tue, 3 May 2022 04:41:01 +0000 (10:11 +0530)
Switch to consistently using the explicit reset-controller API which
makes it clear that the reset controllers are used exclusively by the
PHY driver.

Note that the deprecated of_reset_control_get() and
devm_reset_control_get() are just transitional wrappers for the explicit
API so there's no functional change.

Suggested-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20220427063243.32576-4-johan+linaro@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/qualcomm/phy-qcom-qmp.c

index ac74561..d6581a1 100644 (file)
@@ -5587,7 +5587,7 @@ static int qcom_qmp_phy_reset_init(struct device *dev, const struct qmp_phy_cfg
                struct reset_control *rst;
                const char *name = cfg->reset_list[i];
 
-               rst = devm_reset_control_get(dev, name);
+               rst = devm_reset_control_get_exclusive(dev, name);
                if (IS_ERR(rst)) {
                        dev_err(dev, "failed to get %s reset\n", name);
                        return PTR_ERR(rst);
@@ -5985,7 +5985,7 @@ int qcom_qmp_phy_create(struct device *dev, struct device_node *np, int id,
        /* Get lane reset, if any */
        if (cfg->has_lane_rst) {
                snprintf(prop_name, sizeof(prop_name), "lane%d", id);
-               qphy->lane_rst = of_reset_control_get(np, prop_name);
+               qphy->lane_rst = of_reset_control_get_exclusive(np, prop_name);
                if (IS_ERR(qphy->lane_rst)) {
                        dev_err(dev, "failed to get lane%d reset\n", id);
                        return PTR_ERR(qphy->lane_rst);