OSDN Git Service

serial: 8250_omap: Remove RTS clear
authorPeter Hurley <peter@hurleysoftware.com>
Sat, 10 Oct 2015 18:32:30 +0000 (14:32 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 18 Oct 2015 04:05:46 +0000 (21:05 -0700)
Clearing UART_MCR_RTS or UART_MCR_XONANY is unnecessary; these bits
are never set in the shadow mcr. The RTS clear is especially confusing.

Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_omap.c

index 6efe4dd..a2c0734 100644 (file)
@@ -439,7 +439,6 @@ static void omap_8250_set_termios(struct uart_port *port,
        priv->xoff = termios->c_cc[VSTOP];
 
        priv->efr = 0;
-       up->mcr &= ~(UART_MCR_RTS | UART_MCR_XONANY);
        up->port.status &= ~(UPSTAT_AUTOCTS | UPSTAT_AUTORTS | UPSTAT_AUTOXOFF);
 
        if (termios->c_cflag & CRTSCTS && up->port.flags & UPF_HARD_FLOW) {