OSDN Git Service

crypto: marvell/octeontx - Use kcalloc() instead of kzalloc()
authorGustavo A. R. Silva <gustavoars@kernel.org>
Wed, 8 Dec 2021 04:17:21 +0000 (22:17 -0600)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 17 Dec 2021 05:59:47 +0000 (16:59 +1100)
Use 2-factor multiplication argument form kcalloc() instead
of kzalloc().

Link: https://github.com/KSPP/linux/issues/162
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/marvell/octeontx/otx_cptvf_main.c

index c076d0b..b681bd2 100644 (file)
@@ -94,15 +94,13 @@ static int alloc_pending_queues(struct otx_cpt_pending_qinfo *pqinfo, u32 qlen,
                                u32 num_queues)
 {
        struct otx_cpt_pending_queue *queue = NULL;
-       size_t size;
        int ret;
        u32 i;
 
        pqinfo->num_queues = num_queues;
-       size = (qlen * sizeof(struct otx_cpt_pending_entry));
 
        for_each_pending_queue(pqinfo, queue, i) {
-               queue->head = kzalloc((size), GFP_KERNEL);
+               queue->head = kcalloc(qlen, sizeof(*queue->head), GFP_KERNEL);
                if (!queue->head) {
                        ret = -ENOMEM;
                        goto pending_qfail;