OSDN Git Service

clk: cdce925: release child device nodes
authorAlexey Khoroshilov <khoroshilov@ispras.ru>
Tue, 21 Aug 2018 21:05:32 +0000 (00:05 +0300)
committerStephen Boyd <sboyd@kernel.org>
Thu, 30 Aug 2018 22:19:16 +0000 (15:19 -0700)
of_get_child_by_name() returns device node with refcount incremented,
but there is no decrement in cdce925_probe(). The patch adds one.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/clk-cdce925.c

index 0a7e7d5..e9c3ffa 100644 (file)
@@ -703,6 +703,7 @@ static int cdce925_probe(struct i2c_client *client,
                                0x12 + (i*CDCE925_OFFSET_PLL),
                                0x07, value & 0x07);
                }
+               of_node_put(np_output);
        }
 
        /* Register output clock Y1 */