OSDN Git Service

dyndbg: fix pr_err with empty string
authorJim Cromie <jim.cromie@gmail.com>
Sun, 19 Jul 2020 23:10:48 +0000 (17:10 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 24 Jul 2020 15:00:08 +0000 (17:00 +0200)
this pr_err attempts to print the string after the OP, but the string
has been parsed and chopped up, so looks empty.

Acked-by: <jbaron@akamai.com>
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Link: https://lore.kernel.org/r/20200719231058.1586423-9-jim.cromie@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
lib/dynamic_debug.c

index 0cb5679..1d25a84 100644 (file)
@@ -420,7 +420,7 @@ static int ddebug_parse_flags(const char *str, unsigned int *flagsp,
                        }
                }
                if (i < 0) {
-                       pr_err("unknown flag '%c' in \"%s\"\n", *str, str);
+                       pr_err("unknown flag '%c'\n", *str);
                        return -EINVAL;
                }
        }