OSDN Git Service

net: mvpp2: check return value after calling platform_get_resource()
authorYang Yingliang <yangyingliang@huawei.com>
Mon, 7 Jun 2021 14:36:02 +0000 (22:36 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 7 Jun 2021 21:07:22 +0000 (14:07 -0700)
It will cause null-ptr-deref if platform_get_resource() returns NULL,
we need check the return value.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c

index d4fb620..b0066f6 100644 (file)
@@ -7377,6 +7377,10 @@ static int mvpp2_probe(struct platform_device *pdev)
                        return PTR_ERR(priv->lms_base);
        } else {
                res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
+               if (!res) {
+                       dev_err(&pdev->dev, "Invalid resource\n");
+                       return -EINVAL;
+               }
                if (has_acpi_companion(&pdev->dev)) {
                        /* In case the MDIO memory region is declared in
                         * the ACPI, it can already appear as 'in-use'