OSDN Git Service

net: hns3: make array spec_opcode static const, makes object smaller
authorColin Ian King <colin.king@canonical.com>
Thu, 19 Aug 2021 11:58:13 +0000 (12:58 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 19 Aug 2021 12:23:20 +0000 (13:23 +0100)
Don't populate the array spec_opcode on the stack but instead it
static const. Makes the object code smaller by 158 bytes:

Before:
   text   data   bss     dec    hex filename
  12271   3976   128   16375   3ff7 .../hisilicon/hns3/hns3pf/hclge_cmd.o

After:
   text   data   bss     dec    hex filename
  12017   4072   128   16217   3f59 .../hisilicon/hns3/hns3pf/hclge_cmd.o

(gcc version 10.3.0)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c

index 887297e..13042f1 100644 (file)
@@ -169,17 +169,19 @@ static bool hclge_is_special_opcode(u16 opcode)
        /* these commands have several descriptors,
         * and use the first one to save opcode and return value
         */
-       u16 spec_opcode[] = {HCLGE_OPC_STATS_64_BIT,
-                            HCLGE_OPC_STATS_32_BIT,
-                            HCLGE_OPC_STATS_MAC,
-                            HCLGE_OPC_STATS_MAC_ALL,
-                            HCLGE_OPC_QUERY_32_BIT_REG,
-                            HCLGE_OPC_QUERY_64_BIT_REG,
-                            HCLGE_QUERY_CLEAR_MPF_RAS_INT,
-                            HCLGE_QUERY_CLEAR_PF_RAS_INT,
-                            HCLGE_QUERY_CLEAR_ALL_MPF_MSIX_INT,
-                            HCLGE_QUERY_CLEAR_ALL_PF_MSIX_INT,
-                            HCLGE_QUERY_ALL_ERR_INFO};
+       static const u16 spec_opcode[] = {
+               HCLGE_OPC_STATS_64_BIT,
+               HCLGE_OPC_STATS_32_BIT,
+               HCLGE_OPC_STATS_MAC,
+               HCLGE_OPC_STATS_MAC_ALL,
+               HCLGE_OPC_QUERY_32_BIT_REG,
+               HCLGE_OPC_QUERY_64_BIT_REG,
+               HCLGE_QUERY_CLEAR_MPF_RAS_INT,
+               HCLGE_QUERY_CLEAR_PF_RAS_INT,
+               HCLGE_QUERY_CLEAR_ALL_MPF_MSIX_INT,
+               HCLGE_QUERY_CLEAR_ALL_PF_MSIX_INT,
+               HCLGE_QUERY_ALL_ERR_INFO
+       };
        int i;
 
        for (i = 0; i < ARRAY_SIZE(spec_opcode); i++) {