OSDN Git Service

elf2dmp/pdb: Plug memleak in pdb_init_from_file
authorPan Nengyuan <pannengyuan@huawei.com>
Fri, 23 Oct 2020 06:12:15 +0000 (14:12 +0800)
committerLaurent Vivier <laurent@vivier.eu>
Sun, 13 Dec 2020 22:56:16 +0000 (23:56 +0100)
Missing g_error_free in pdb_init_from_file() error path. Fix that.

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
Reviewed-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20201023061218.2080844-5-kuhn.chenqun@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
contrib/elf2dmp/pdb.c

index a5bd40c..b3a6547 100644 (file)
@@ -285,6 +285,7 @@ int pdb_init_from_file(const char *name, struct pdb_reader *reader)
     reader->gmf = g_mapped_file_new(name, TRUE, &gerr);
     if (gerr) {
         eprintf("Failed to map PDB file \'%s\'\n", name);
+        g_error_free(gerr);
         return 1;
     }