OSDN Git Service

net: x25: mark expected switch fall-throughs
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Fri, 20 Oct 2017 17:37:52 +0000 (12:37 -0500)
committerDavid S. Miller <davem@davemloft.net>
Sun, 22 Oct 2017 02:08:46 +0000 (03:08 +0100)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/x25/x25_facilities.c
net/x25/x25_in.c

index 997ff7b..ad1734d 100644 (file)
@@ -103,7 +103,7 @@ int x25_parse_facilities(struct sk_buff *skb, struct x25_facilities *facilities,
                                        *vc_fac_mask |= X25_MASK_REVERSE;
                                        break;
                                }
-
+                               /*fall through */
                        case X25_FAC_THROUGHPUT:
                                facilities->throughput = p[1];
                                *vc_fac_mask |= X25_MASK_THROUGHPUT;
index 7ac5009..3c12cae 100644 (file)
@@ -345,6 +345,7 @@ static int x25_state4_machine(struct sock *sk, struct sk_buff *skb, int frametyp
 
                case X25_RESET_REQUEST:
                        x25_write_internal(sk, X25_RESET_CONFIRMATION);
+                       /* fall through */
                case X25_RESET_CONFIRMATION: {
                        x25_stop_timer(sk);
                        x25->condition = 0x00;