OSDN Git Service
(root)
/
uclinux-h8
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
5b2aa9f
)
dmaengine: at_hdmac: check return value of of_find_device_by_node() in at_dma_xlate()
author
Yu Kuai
<yukuai3@huawei.com>
Mon, 17 Aug 2020 11:57:26 +0000
(19:57 +0800)
committer
Vinod Koul
<vkoul@kernel.org>
Wed, 19 Aug 2020 04:28:37 +0000
(09:58 +0530)
The reurn value of of_find_device_by_node() is not checked, thus null
pointer dereference will be triggered if of_find_device_by_node()
failed.
Fixes:
bbe89c8e3d59
("at_hdmac: move to generic DMA binding")
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Link:
https://lore.kernel.org/r/20200817115728.1706719-2-yukuai3@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/at_hdmac.c
patch
|
blob
|
history
diff --git
a/drivers/dma/at_hdmac.c
b/drivers/dma/at_hdmac.c
index
45bbcd6
..
1c941f8
100644
(file)
--- a/
drivers/dma/at_hdmac.c
+++ b/
drivers/dma/at_hdmac.c
@@
-1650,6
+1650,8
@@
static struct dma_chan *at_dma_xlate(struct of_phandle_args *dma_spec,
return NULL;
dmac_pdev = of_find_device_by_node(dma_spec->np);
+ if (!dmac_pdev)
+ return NULL;
dma_cap_zero(mask);
dma_cap_set(DMA_SLAVE, mask);