OSDN Git Service

Input: synaptics-rmi4 - constify attribute_group structures in F01
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Tue, 11 Jul 2017 03:17:05 +0000 (20:17 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 12 Jul 2017 21:18:28 +0000 (14:18 -0700)
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.

File size before:
   text    data     bss     dec     hex filename
   4777     480       0    5257    1489 drivers/input/rmi4/rmi_f01.o

File size After adding 'const':
   text    data     bss     dec     hex filename
   4817     416       0    5233    1471 drivers/input/rmi4/rmi_f01.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/rmi4/rmi_f01.c

index 7f7e917..aa1aabf 100644 (file)
@@ -334,7 +334,7 @@ static struct attribute *rmi_f01_attrs[] = {
        NULL
 };
 
-static struct attribute_group rmi_f01_attr_group = {
+static const struct attribute_group rmi_f01_attr_group = {
        .attrs = rmi_f01_attrs,
 };