OSDN Git Service

Fixed a bug where the panel could get stuck closing
authorSelim Cinek <cinek@google.com>
Mon, 2 Nov 2015 21:42:58 +0000 (13:42 -0800)
committerThe Android Automerger <android-build@google.com>
Tue, 3 Nov 2015 22:35:14 +0000 (14:35 -0800)
When mClosing was set even though the panel was not
expanding, the variable was never reset leading to
bad states like the notification shade not updating,
people missing calls and similar bad bugs.

Bug: 25338991
Change-Id: I4362fda257770c98c5f9ba75a5622b14f74dc5ae

packages/SystemUI/src/com/android/systemui/statusbar/phone/PanelView.java

index c6743e7..e03bcfb 100644 (file)
@@ -123,7 +123,6 @@ public abstract class PanelView extends FrameLayout {
     };
 
     protected void onExpandingFinished() {
-        endClosing();
         mBar.onExpandingFinished();
     }
 
@@ -138,6 +137,7 @@ public abstract class PanelView extends FrameLayout {
     }
 
     protected final void notifyExpandingFinished() {
+        endClosing();
         if (mExpanding) {
             mExpanding = false;
             onExpandingFinished();