OSDN Git Service

iio: adc: cpcap-adc: Fix missing IRQF_ONESHOT as only threaded handler.
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 13 Oct 2019 16:21:33 +0000 (17:21 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Fri, 18 Oct 2019 19:02:50 +0000 (20:02 +0100)
Coccinelle noticed:
CHECK   drivers/iio/adc/cpcap-adc.c
drivers/iio/adc/cpcap-adc.c:1009:9-34: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

As far as I can see this is a simple case of it should be specified
but isn't.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Acked-by: Tony Lindgren <tony@atomide.com>
drivers/iio/adc/cpcap-adc.c

index 2d616ca..5086a33 100644 (file)
@@ -1008,7 +1008,7 @@ static int cpcap_adc_probe(struct platform_device *pdev)
 
        error = devm_request_threaded_irq(&pdev->dev, ddata->irq, NULL,
                                          cpcap_adc_irq_thread,
-                                         IRQF_TRIGGER_NONE,
+                                         IRQF_TRIGGER_NONE | IRQF_ONESHOT,
                                          "cpcap-adc", indio_dev);
        if (error) {
                dev_err(&pdev->dev, "could not get irq: %i\n",