Allow plpgsql IN parameters to be assigned to. Since the parameters are just

preinitialized local variables, this does not affect the function's semantics
as seen by callers; allowing assignment simply avoids the need to create more
local variables in some cases.  In any case we were being rather inconsistent
since only scalar parameters were getting marked constant.

No documentation change, since parameters were never documented as being
marked constant anyway.

Steve Prentice

diff --git a/src/pl/plpgsql/src/pl_comp.c b/src/pl/plpgsql/src/pl_comp.c
index 1b501d5..c589aa1 100644 (file)
--- a/src/pl/plpgsql/src/pl_comp.c
+++ b/src/pl/plpgsql/src/pl_comp.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *       $PostgreSQL: pgsql/src/pl/plpgsql/src/pl_comp.c,v 1.137 2009/07/12 17:12:34 tgl Exp $
+ *       $PostgreSQL: pgsql/src/pl/plpgsql/src/pl_comp.c,v 1.138 2009/09/20 01:53:32 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -424,10 +424,6 @@ do_compile(FunctionCallInfo fcinfo,
                                if (argvariable->dtype == PLPGSQL_DTYPE_VAR)
                                {
                                        argitemtype = PLPGSQL_NSTYPE_VAR;
-                                       /* input argument vars are forced to be CONSTANT */
-                                       if (argmode == PROARGMODE_IN ||
-                                               argmode == PROARGMODE_VARIADIC)
-                                               ((PLpgSQL_var *) argvariable)->isconst = true;
                                }
                                else
                                {