OSDN Git Service

media: via-camera: set device_caps in struct video_device
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Wed, 26 Jun 2019 07:15:23 +0000 (03:15 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Mon, 22 Jul 2019 19:08:18 +0000 (15:08 -0400)
Instead of filling in the struct v4l2_capability device_caps
field, fill in the struct video_device device_caps field.

That way the V4L2 core knows what the capabilities of the
video device are.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/via-camera.c

index d5f8118..4110dc4 100644 (file)
@@ -988,9 +988,6 @@ static int viacam_querycap(struct file *filp, void *priv,
 {
        strscpy(cap->driver, "via-camera", sizeof(cap->driver));
        strscpy(cap->card, "via-camera", sizeof(cap->card));
-       cap->device_caps = V4L2_CAP_VIDEO_CAPTURE |
-               V4L2_CAP_READWRITE | V4L2_CAP_STREAMING;
-       cap->capabilities = cap->device_caps | V4L2_CAP_DEVICE_CAPS;
        return 0;
 }
 
@@ -1267,6 +1264,8 @@ static const struct video_device viacam_v4l_template = {
        .fops           = &viacam_fops,
        .ioctl_ops      = &viacam_ioctl_ops,
        .release        = video_device_release_empty, /* Check this */
+       .device_caps    = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_READWRITE |
+                         V4L2_CAP_STREAMING,
 };
 
 /*