OSDN Git Service
(root)
/
uclinux-h8
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
858aa5a
)
drm: simpledrm: Fix use after free issues
author
Colin Ian King
<colin.king@canonical.com>
Wed, 12 May 2021 20:30:51 +0000
(21:30 +0100)
committer
Thomas Zimmermann
<tzimmermann@suse.de>
Thu, 13 May 2021 14:00:54 +0000
(16:00 +0200)
There are two occurrances where objects are being free'd via
a put call and yet they are being referenced after this. Fix these
by adding in the missing continue statement so that the put on the
end of the loop is skipped over.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Addresses-Coverity: ("Use after free")
Fixes:
11e8f5fd223b
("drm: Add simpledrm driver")
Link:
https://patchwork.freedesktop.org/patch/msgid/20210512203051.299026-1-colin.king@canonical.com
drivers/gpu/drm/tiny/simpledrm.c
patch
|
blob
|
history
diff --git
a/drivers/gpu/drm/tiny/simpledrm.c
b/drivers/gpu/drm/tiny/simpledrm.c
index
00e118c
..
f72ca3a
100644
(file)
--- a/
drivers/gpu/drm/tiny/simpledrm.c
+++ b/
drivers/gpu/drm/tiny/simpledrm.c
@@
-298,6
+298,7
@@
static int simpledrm_device_init_clocks(struct simpledrm_device *sdev)
drm_err(dev, "failed to enable clock %u: %d\n",
i, ret);
clk_put(clock);
+ continue;
}
sdev->clks[i] = clock;
}
@@
-415,6
+416,7
@@
static int simpledrm_device_init_regulators(struct simpledrm_device *sdev)
drm_err(dev, "failed to enable regulator %u: %d\n",
i, ret);
regulator_put(regulator);
+ continue;
}
sdev->regulators[i++] = regulator;