OSDN Git Service

Fixed obsolete TODOs.
authorFelipe Leme <felipeal@google.com>
Tue, 14 Mar 2017 15:40:06 +0000 (08:40 -0700)
committerFelipe Leme <felipeal@google.com>
Tue, 14 Mar 2017 15:41:49 +0000 (08:41 -0700)
Test: not needed
Bug: 35395043
Bug: 26742218

Change-Id: I0e5adb574610374055a6546b66529a7aed7cc413

core/java/android/os/storage/StorageVolume.java
core/java/android/service/autofill/AutofillServiceInfo.java
services/autofill/java/com/android/server/autofill/RemoteFillService.java

index 46f2d38..1fc0b82 100644 (file)
@@ -373,8 +373,7 @@ public final class StorageVolume implements Parcelable {
     }
 
     /** {@hide} */
-    // TODO(b/26742218): find out where toString() is called internally and replace these calls by
-    // dump().
+    // TODO: find out where toString() is called internally and replace these calls by dump().
     public String dump() {
         final CharArrayWriter writer = new CharArrayWriter();
         dump(new IndentingPrintWriter(writer, "    ", 80));
index d220052..f6d40db 100644 (file)
@@ -78,14 +78,12 @@ public final class AutofillServiceInfo {
             // TODO(b/35956626): inline newSettingsActivity once clients migrate
             final String newSettingsActivity =
                     metaDataArray.getString(R.styleable.AutofillService_settingsActivity);
-            System.out.println(">>> NEW CRAP MAN: " + newSettingsActivity); // TODO(felipeal): tmp
             if (newSettingsActivity != null) {
                 mSettingsActivity = newSettingsActivity;
             } else {
                 mSettingsActivity =
                         metaDataArray.getString(R.styleable.AutoFillService_settingsActivity);
             }
-            System.out.println(">>> FINAL CRAP MAN: " + mSettingsActivity); // TODO(felipeal): tmp
             metaDataArray.recycle();
         } else {
             mSettingsActivity = null;
index eeff37c..47251db 100644 (file)
@@ -240,7 +240,7 @@ final class RemoteFillService implements DeathRecipient {
         }
         mBinding = false;
         if (isBound()) {
-            // TODO(b/33197203, b/35395043): synchronize access instead
+            // TODO(b/33197203): synchronize access instead?
             // Need to double check if it's null, since it could be set on onServiceDisconnected()
             if (mAutoFillService != null) {
                 try {
@@ -322,7 +322,7 @@ final class RemoteFillService implements DeathRecipient {
             }
 
             try {
-                // TODO(b/33197203, b/35395043): synchronize access instead
+                // TODO(b/33197203): synchronize access instead?
                 // Need to double check if it's null, since it could be set on
                 // onServiceDisconnected()
                 if (mAutoFillService != null) {