OSDN Git Service

fm10k: only warn when stop_hw fails with FM10K_ERR_REQUESTS_PENDING
authorJacob Keller <jacob.e.keller@intel.com>
Tue, 7 Jun 2016 23:08:50 +0000 (16:08 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Wed, 20 Jul 2016 22:22:12 +0000 (15:22 -0700)
When stop_hw() routine fails with FM10K_ERR_REQUESTS_PENDING, this
indicates that the Tx or Rx queues did not shutdown within the time
limit. Print a more suitable message at the dev_info level instead of
dev_err.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Krishneil Singh <Krishneil.k.singh@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/fm10k/fm10k_pci.c

index 4439376..4dfd128 100644 (file)
@@ -1644,7 +1644,10 @@ void fm10k_down(struct fm10k_intfc *interface)
 
        /* Disable DMA engine for Tx/Rx */
        err = hw->mac.ops.stop_hw(hw);
-       if (err)
+       if (err == FM10K_ERR_REQUESTS_PENDING)
+               dev_info(&interface->pdev->dev,
+                        "due to pending requests hw was not shut down gracefully\n");
+       else if (err)
                dev_err(&interface->pdev->dev, "stop_hw failed: %d\n", err);
 
        /* free any buffers still on the rings */