OSDN Git Service

scsi: sun_esp: don't use GFP_ATOMIC for command block allocation
authorChristoph Hellwig <hch@lst.de>
Sat, 13 Oct 2018 07:26:24 +0000 (09:26 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 16 Oct 2018 03:00:38 +0000 (23:00 -0400)
esp_sbus_map_command_block is called straight from the probe routine
without any locks held, so we can safely use GFP_KERNEL here.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Tested-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sun_esp.c

index 747ee64..c7b60ed 100644 (file)
@@ -104,7 +104,7 @@ static int esp_sbus_map_command_block(struct esp *esp)
 
        esp->command_block = dma_alloc_coherent(&op->dev, 16,
                                                &esp->command_block_dma,
-                                               GFP_ATOMIC);
+                                               GFP_KERNEL);
        if (!esp->command_block)
                return -ENOMEM;
        return 0;