OSDN Git Service

drm: checking the wrong variable in savage_do_init_bci()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 17 May 2012 07:09:44 +0000 (10:09 +0300)
committerDave Airlie <airlied@redhat.com>
Thu, 17 May 2012 10:42:27 +0000 (11:42 +0100)
drm_core_ioremap() initializes ->handle.  We already know
"dev->agp_buffer_map" is a valid pointer.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/savage/savage_bci.c

index cb1ee4e..6eb507a 100644 (file)
@@ -735,7 +735,7 @@ static int savage_do_init_bci(struct drm_device * dev, drm_savage_init_t * init)
                        return -EINVAL;
                }
                drm_core_ioremap(dev->agp_buffer_map, dev);
-               if (!dev->agp_buffer_map) {
+               if (!dev->agp_buffer_map->handle) {
                        DRM_ERROR("failed to ioremap DMA buffer region!\n");
                        savage_do_cleanup_bci(dev);
                        return -ENOMEM;