OSDN Git Service

drm/i915/pipe_crc: automatic conversion to drm_device based logging macros.
authorWambui Karuga <wambui.karugax@gmail.com>
Thu, 30 Jan 2020 08:32:28 +0000 (11:32 +0300)
committerJani Nikula <jani.nikula@intel.com>
Tue, 4 Feb 2020 09:13:45 +0000 (11:13 +0200)
Conversion of various instances of the printk based logging macros to
the new struct drm_device based logging macros in
i915/display/intel_pipe_crc.c using the following coccinelle script that
transforms based on the existence of a drm_i915_private device pointer:
@@
identifier fn, T;
@@

fn(...) {
...
struct drm_i915_private *T = ...;
<+...
(
-DRM_INFO(
+drm_info(&T->drm,
...)
|
-DRM_ERROR(
+drm_err(&T->drm,
...)
|
-DRM_WARN(
+drm_warn(&T->drm,
...)
|
-DRM_DEBUG(
+drm_dbg(&T->drm,
...)
|
-DRM_DEBUG_KMS(
+drm_dbg_kms(&T->drm,
...)
|
-DRM_DEBUG_DRIVER(
+drm_dbg(&T->drm,
...)
|
-DRM_DEBUG_ATOMIC(
+drm_dbg_atomic(&T->drm,
...)
)
...+>
}

@@
identifier fn, T;
@@

fn(...,struct drm_i915_private *T,...) {
<+...
(
-DRM_INFO(
+drm_info(&T->drm,
...)
|
-DRM_ERROR(
+drm_err(&T->drm,
...)
|
-DRM_WARN(
+drm_warn(&T->drm,
...)
|
-DRM_DEBUG(
+drm_dbg(&T->drm,
...)
|
-DRM_DEBUG_DRIVER(
+drm_dbg(&T->drm,
...)
|
-DRM_DEBUG_KMS(
+drm_dbg_kms(&T->drm,
...)
|
-DRM_DEBUG_ATOMIC(
+drm_dbg_atomic(&T->drm,
...)
)
...+>
}

Checkpatch warnings were addressed manually.

Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200130083229.12889-12-wambui.karugax@gmail.com
drivers/gpu/drm/i915/display/intel_pipe_crc.c

index d0f0585..59d7e3c 100644 (file)
@@ -571,7 +571,7 @@ int intel_crtc_verify_crc_source(struct drm_crtc *crtc, const char *source_name,
        enum intel_pipe_crc_source source;
 
        if (display_crc_ctl_parse_source(source_name, &source) < 0) {
-               DRM_DEBUG_DRIVER("unknown source %s\n", source_name);
+               drm_dbg(&dev_priv->drm, "unknown source %s\n", source_name);
                return -EINVAL;
        }
 
@@ -596,14 +596,15 @@ int intel_crtc_set_crc_source(struct drm_crtc *crtc, const char *source_name)
        bool enable;
 
        if (display_crc_ctl_parse_source(source_name, &source) < 0) {
-               DRM_DEBUG_DRIVER("unknown source %s\n", source_name);
+               drm_dbg(&dev_priv->drm, "unknown source %s\n", source_name);
                return -EINVAL;
        }
 
        power_domain = POWER_DOMAIN_PIPE(crtc->index);
        wakeref = intel_display_power_get_if_enabled(dev_priv, power_domain);
        if (!wakeref) {
-               DRM_DEBUG_KMS("Trying to capture CRC while pipe is off\n");
+               drm_dbg_kms(&dev_priv->drm,
+                           "Trying to capture CRC while pipe is off\n");
                return -EIO;
        }