ethtool: add PRIVFLAGS_NTF notification

Send ETHTOOL_MSG_PRIVFLAGS_NTF notification whenever private flags of
a network device are modified using ETHTOOL_MSG_PRIVFLAGS_SET netlink
message or ETHTOOL_SPFLAGS ioctl request.

Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/include/uapi/linux/ethtool_netlink.h b/include/uapi/linux/ethtool_netlink.h
index 13e631c..7f23a7f 100644 (file)
--- a/include/uapi/linux/ethtool_netlink.h
+++ b/include/uapi/linux/ethtool_netlink.h
@@ -51,6 +51,7 @@ enum {
        ETHTOOL_MSG_FEATURES_SET_REPLY,
        ETHTOOL_MSG_FEATURES_NTF,
        ETHTOOL_MSG_PRIVFLAGS_GET_REPLY,
+       ETHTOOL_MSG_PRIVFLAGS_NTF,
 
        /* add new constants above here */
        __ETHTOOL_MSG_KERNEL_CNT,

diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c
index 45d1bf1..2988222 100644 (file)
--- a/net/ethtool/ioctl.c
+++ b/net/ethtool/ioctl.c
@@ -2716,6 +2716,8 @@ int dev_ethtool(struct net *net, struct ifreq *ifr)
        case ETHTOOL_GPFLAGS:
                rc = ethtool_get_value(dev, useraddr, ethcmd,
                                       dev->ethtool_ops->get_priv_flags);
+               if (!rc)
+                       ethtool_notify(dev, ETHTOOL_MSG_PRIVFLAGS_NTF, NULL);
                break;
        case ETHTOOL_SPFLAGS:
                rc = ethtool_set_value(dev, useraddr,

diff --git a/net/ethtool/netlink.c b/net/ethtool/netlink.c
index b6795aa..dec82b0 100644 (file)
--- a/net/ethtool/netlink.c
+++ b/net/ethtool/netlink.c
@@ -530,6 +530,7 @@ ethnl_default_notify_ops[ETHTOOL_MSG_KERNEL_MAX + 1] = {
        [ETHTOOL_MSG_DEBUG_NTF]         = &ethnl_debug_request_ops,
        [ETHTOOL_MSG_WOL_NTF]           = &ethnl_wol_request_ops,
        [ETHTOOL_MSG_FEATURES_NTF]      = &ethnl_features_request_ops,
+       [ETHTOOL_MSG_PRIVFLAGS_NTF]     = &ethnl_privflags_request_ops,
 };
 
 /* default notification handler */
@@ -616,6 +617,7 @@ static const ethnl_notify_handler_t ethnl_notify_handlers[] = {
        [ETHTOOL_MSG_DEBUG_NTF]         = ethnl_default_notify,
        [ETHTOOL_MSG_WOL_NTF]           = ethnl_default_notify,
        [ETHTOOL_MSG_FEATURES_NTF]      = ethnl_default_notify,
+       [ETHTOOL_MSG_PRIVFLAGS_NTF]     = ethnl_default_notify,
 };
 
 void ethtool_notify(struct net_device *dev, unsigned int cmd, const void *data)

diff --git a/net/ethtool/privflags.c b/net/ethtool/privflags.c
index dfa76d5..e8f03b3 100644 (file)
--- a/net/ethtool/privflags.c
+++ b/net/ethtool/privflags.c
@@ -194,6 +194,9 @@ int ethnl_set_privflags(struct sk_buff *skb, struct genl_info *info)
        if (ret < 0 || !mod)
                goto out_free;
        ret = ops->set_priv_flags(dev, flags);
+       if (ret < 0)
+               goto out_free;
+       ethtool_notify(dev, ETHTOOL_MSG_PRIVFLAGS_NTF, NULL);
 
 out_free:
        kfree(names);