OSDN Git Service

regulator: s2mpa01: Use correct register for buck1 ramp delay
authorKrzysztof Kozlowski <k.kozlowski@samsung.com>
Mon, 26 May 2014 08:26:46 +0000 (10:26 +0200)
committerMark Brown <broonie@linaro.org>
Mon, 26 May 2014 14:39:12 +0000 (15:39 +0100)
Fix the register for ramp delay of buck1 regulator. Buck1 and buck6
share the field (offset 4) in ramp delay register S2MPA01_REG_RAMP2.

The driver used the same register and field for ramp delay of buck3 and
buck1. This lead to updating of ramp delay of buck3 when setting buck1
and actually the ramp delay of buck1 was never set.

Fixes: f18792714608 ("regulator: Add support for S2MPA01 regulator")
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
Cc: <stable@vger.kernel.org>
drivers/regulator/s2mpa01.c

index f19a30f..a52cb1c 100644 (file)
@@ -116,7 +116,6 @@ static int s2mpa01_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay)
                        ramp_delay = s2mpa01->ramp_delay16;
 
                ramp_shift = S2MPA01_BUCK16_RAMP_SHIFT;
-               ramp_reg = S2MPA01_REG_RAMP1;
                break;
        case S2MPA01_BUCK2:
                enable_shift = S2MPA01_BUCK2_RAMP_EN_SHIFT;