OSDN Git Service

staging: rts5208: fix memleaks on error handling paths in probe
authorEvgeny Novikov <novikov@ispras.ru>
Tue, 23 Jun 2020 14:12:30 +0000 (17:12 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Jun 2020 13:40:27 +0000 (15:40 +0200)
rtsx_probe() allocates host, but does not free it on error handling
paths. The patch adds missed scsi_host_put().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
Link: https://lore.kernel.org/r/20200623141230.7258-1-novikov@ispras.ru
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rts5208/rtsx.c

index be0053c..937f4e7 100644 (file)
@@ -972,6 +972,7 @@ ioremap_fail:
        kfree(dev->chip);
 chip_alloc_fail:
        dev_err(&pci->dev, "%s failed\n", __func__);
+       scsi_host_put(host);
 scsi_host_alloc_fail:
        pci_release_regions(pci);
        return err;