OSDN Git Service

usb: dwc3: xilinx: Remove the extra freeing of clocks
authorManish Narani <manish.narani@xilinx.com>
Thu, 8 Apr 2021 17:54:08 +0000 (23:24 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 9 Apr 2021 14:05:32 +0000 (16:05 +0200)
The clocks are configured by devm_clk_bulk_get_all() in this driver. In
case of any error the clocks freeing will be handled automatically.
There is no need to explicitly free the clocks. Fix the same.

Fixes: 84770f028fab ("usb: dwc3: Add driver for Xilinx platforms")
Signed-off-by: Manish Narani <manish.narani@xilinx.com>
Link: https://lore.kernel.org/r/1617904448-74611-3-git-send-email-manish.narani@xilinx.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/dwc3-xilinx.c

index f42f4cb..9cc3ad7 100644 (file)
@@ -271,7 +271,6 @@ static int dwc3_xlnx_probe(struct platform_device *pdev)
 
 err_clk_put:
        clk_bulk_disable_unprepare(priv_data->num_clocks, priv_data->clks);
-       clk_bulk_put_all(priv_data->num_clocks, priv_data->clks);
 
        return ret;
 }
@@ -284,7 +283,6 @@ static int dwc3_xlnx_remove(struct platform_device *pdev)
        of_platform_depopulate(dev);
 
        clk_bulk_disable_unprepare(priv_data->num_clocks, priv_data->clks);
-       clk_bulk_put_all(priv_data->num_clocks, priv_data->clks);
        priv_data->num_clocks = 0;
 
        pm_runtime_disable(dev);