OSDN Git Service

PCI: cadence: Prefer of_device_get_match_data()
authorFan Fei <ffclaire1224@gmail.com>
Thu, 23 Dec 2021 01:10:34 +0000 (19:10 -0600)
committerBjorn Helgaas <bhelgaas@google.com>
Mon, 3 Jan 2022 21:01:04 +0000 (15:01 -0600)
The cadence driver only needs the device data, not the whole struct
of_device_id.  Use of_device_get_match_data() instead of of_match_device().
No functional change intended.

[bhelgaas: commit log]
Link: https://lore.kernel.org/r/20211223011054.1227810-4-helgaas@kernel.org
Signed-off-by: Fan Fei <ffclaire1224@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Tom Joseph <tjoseph@cadence.com>
drivers/pci/controller/cadence/pcie-cadence-plat.c

index a224afa..bac0541 100644 (file)
@@ -45,7 +45,6 @@ static int cdns_plat_pcie_probe(struct platform_device *pdev)
 {
        const struct cdns_plat_pcie_of_data *data;
        struct cdns_plat_pcie *cdns_plat_pcie;
-       const struct of_device_id *match;
        struct device *dev = &pdev->dev;
        struct pci_host_bridge *bridge;
        struct cdns_pcie_ep *ep;
@@ -54,11 +53,10 @@ static int cdns_plat_pcie_probe(struct platform_device *pdev)
        bool is_rc;
        int ret;
 
-       match = of_match_device(cdns_plat_pcie_of_match, dev);
-       if (!match)
+       data = of_device_get_match_data(dev);
+       if (!data)
                return -EINVAL;
 
-       data = (struct cdns_plat_pcie_of_data *)match->data;
        is_rc = data->is_rc;
 
        pr_debug(" Started %s with is_rc: %d\n", __func__, is_rc);