OSDN Git Service

net: hns3: remove unnecessary updating port based VLAN
authorJian Shen <shenjian15@huawei.com>
Mon, 31 May 2021 02:38:40 +0000 (10:38 +0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 1 Jun 2021 05:53:07 +0000 (22:53 -0700)
For the PF have called hclge_update_port_base_vlan_cfg() already
before notify VF, it's unnecessary to update port based VLAN again
when received mailbox request from VF.

Signed-off-by: Jian Shen <shenjian15@huawei.com>
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c

index 16b42ce..3f7d1f2 100644 (file)
@@ -360,15 +360,6 @@ static int hclge_set_vf_vlan_cfg(struct hclge_vport *vport,
                bool en = msg_cmd->is_kill ? true : false;
 
                status = hclge_en_hw_strip_rxvtag(handle, en);
-       } else if (msg_cmd->subcode == HCLGE_MBX_PORT_BASE_VLAN_CFG) {
-               struct hclge_vlan_info *vlan_info;
-               u16 *state;
-
-               state = (u16 *)&mbx_req->msg.data[HCLGE_MBX_VLAN_STATE_OFFSET];
-               vlan_info = (struct hclge_vlan_info *)
-                       &mbx_req->msg.data[HCLGE_MBX_VLAN_INFO_OFFSET];
-               status = hclge_update_port_base_vlan_cfg(vport, *state,
-                                                        vlan_info);
        } else if (msg_cmd->subcode == HCLGE_MBX_GET_PORT_BASE_VLAN_STATE) {
                struct hnae3_ae_dev *ae_dev = pci_get_drvdata(vport->nic.pdev);
                /* vf does not need to know about the port based VLAN state