OSDN Git Service

crypto: sa2ul - Fix PM reference leak in sa_ul_probe()
authorShixin Liu <liushixin2@huawei.com>
Thu, 8 Apr 2021 07:18:37 +0000 (15:18 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 16 Apr 2021 11:16:33 +0000 (21:16 +1000)
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Signed-off-by: Shixin Liu <liushixin2@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/sa2ul.c

index ca7484a..b0f0502 100644 (file)
@@ -2354,7 +2354,7 @@ static int sa_ul_probe(struct platform_device *pdev)
        dev_set_drvdata(sa_k3_dev, dev_data);
 
        pm_runtime_enable(dev);
-       ret = pm_runtime_get_sync(dev);
+       ret = pm_runtime_resume_and_get(dev);
        if (ret < 0) {
                dev_err(&pdev->dev, "%s: failed to get sync: %d\n", __func__,
                        ret);