OSDN Git Service

serial: imx: drop if that always evaluates to true
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Sun, 18 Feb 2018 21:02:42 +0000 (22:02 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Feb 2018 14:29:58 +0000 (15:29 +0100)
The check sts & USR1_DTRD was just evaluated to true two lines above.
So this change doesn't have any effect on the semantic of the driver.

Fixes: 27e16501052e ("serial: imx: implement DSR irq handling for DTE mode")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Shawn Guo <shawnguo@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/imx.c

index ace9628..6c926f7 100644 (file)
@@ -781,8 +781,7 @@ static irqreturn_t imx_int(int irq, void *dev_id)
        if (sts & USR1_DTRD) {
                unsigned long flags;
 
-               if (sts & USR1_DTRD)
-                       writel(USR1_DTRD, sport->port.membase + USR1);
+               writel(USR1_DTRD, sport->port.membase + USR1);
 
                spin_lock_irqsave(&sport->port.lock, flags);
                imx_mctrl_check(sport);