OSDN Git Service

igc: fix error return handling from call to netif_set_real_num_tx_queues
authorColin Ian King <colin.king@canonical.com>
Fri, 19 Oct 2018 18:16:15 +0000 (19:16 +0100)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Wed, 7 Nov 2018 17:47:01 +0000 (09:47 -0800)
The call to netif_set_real_num_tx_queues is not assigning the error
return to variable err even though the next line checks err for an
error.  Fix this by adding the missing err assignment.

Detected by CoverityScan, CID#1474551 ("Logically dead code")

Fixes: 3df25e4c1e66 ("igc: Add interrupt support")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Sasha Neftin <sasha.neftin@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/igc/igc_main.c

index 529c3e9..f176540 100644 (file)
@@ -3358,7 +3358,7 @@ static int __igc_open(struct net_device *netdev, bool resuming)
                goto err_req_irq;
 
        /* Notify the stack of the actual queue counts. */
-       netif_set_real_num_tx_queues(netdev, adapter->num_tx_queues);
+       err = netif_set_real_num_tx_queues(netdev, adapter->num_tx_queues);
        if (err)
                goto err_set_queues;