OSDN Git Service

drm/etnaviv: remove check for return value of drm_debugfs_create_files()
authorWambui Karuga <wambui.karugax@gmail.com>
Tue, 10 Mar 2020 13:31:11 +0000 (16:31 +0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 18 Mar 2020 15:23:37 +0000 (16:23 +0100)
Since commit 987d65d01356 (drm: debugfs: make
drm_debugfs_create_files() never fail), drm_debugfs_create_files() never
fails and only returns 0. Therefore, remove the unnecessary check of its
return value and error handling in etnaviv_debugfs_init() and have the
function return 0 directly.

v2: have etnaviv_debugfs_init() return 0 instead of void to ensure
individual compilation and avoid build breakage.

References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html
Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
Acked-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20200310133121.27913-8-wambui.karugax@gmail.com
drivers/gpu/drm/etnaviv/etnaviv_drv.c

index 6b43c1c..a65d30a 100644 (file)
@@ -233,19 +233,11 @@ static struct drm_info_list etnaviv_debugfs_list[] = {
 
 static int etnaviv_debugfs_init(struct drm_minor *minor)
 {
-       struct drm_device *dev = minor->dev;
-       int ret;
-
-       ret = drm_debugfs_create_files(etnaviv_debugfs_list,
-                       ARRAY_SIZE(etnaviv_debugfs_list),
-                       minor->debugfs_root, minor);
+       drm_debugfs_create_files(etnaviv_debugfs_list,
+                                ARRAY_SIZE(etnaviv_debugfs_list),
+                                minor->debugfs_root, minor);
 
-       if (ret) {
-               dev_err(dev->dev, "could not install etnaviv_debugfs_list\n");
-               return ret;
-       }
-
-       return ret;
+       return 0;
 }
 #endif