OSDN Git Service

drm/i915/fbc: s/false/0/
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 13 Apr 2022 15:28:52 +0000 (18:28 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 25 Apr 2022 15:48:03 +0000 (18:48 +0300)
intel_fbc_check_plane() is supposed to an int, not a boolean.
So replace the bogus 'return false's with the correct 'return 0's.
These were accidental copy-paste mistakes when the code got moved
into intel_fbc_check_plane() from somewhere else tht did return
a boolean.

No functional issue here since false==0.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220413152852.7336-2-ville.syrjala@linux.intel.com
Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
drivers/gpu/drm/i915/display/intel_fbc.c

index 3cbc65a..bbdc34a 100644 (file)
@@ -1094,7 +1094,7 @@ static int intel_fbc_check_plane(struct intel_atomic_state *state,
         */
        if (DISPLAY_VER(i915) >= 12 && crtc_state->has_psr2) {
                plane_state->no_fbc_reason = "PSR2 enabled";
-               return false;
+               return 0;
        }
 
        if (!pixel_format_is_valid(plane_state)) {
@@ -1120,7 +1120,7 @@ static int intel_fbc_check_plane(struct intel_atomic_state *state,
        if (plane_state->hw.pixel_blend_mode != DRM_MODE_BLEND_PIXEL_NONE &&
            fb->format->has_alpha) {
                plane_state->no_fbc_reason = "per-pixel alpha not supported";
-               return false;
+               return 0;
        }
 
        if (!intel_fbc_hw_tracking_covers_screen(plane_state)) {
@@ -1136,7 +1136,7 @@ static int intel_fbc_check_plane(struct intel_atomic_state *state,
        if (DISPLAY_VER(i915) >= 9 &&
            plane_state->view.color_plane[0].y & 3) {
                plane_state->no_fbc_reason = "plane start Y offset misaligned";
-               return false;
+               return 0;
        }
 
        /* Wa_22010751166: icl, ehl, tgl, dg1, rkl */
@@ -1144,7 +1144,7 @@ static int intel_fbc_check_plane(struct intel_atomic_state *state,
            (plane_state->view.color_plane[0].y +
             (drm_rect_height(&plane_state->uapi.src) >> 16)) & 3) {
                plane_state->no_fbc_reason = "plane end Y offset misaligned";
-               return false;
+               return 0;
        }
 
        /* WaFbcExceedCdClockThreshold:hsw,bdw */