OSDN Git Service

drm/msm/mdp4: mark symbols static where possible
authorBaoyou Xie <baoyou.xie@linaro.org>
Wed, 7 Sep 2016 10:58:44 +0000 (18:58 +0800)
committerRob Clark <robdclark@gmail.com>
Thu, 15 Sep 2016 21:21:11 +0000 (17:21 -0400)
We get 2 warnings when building kernel with W=1:
drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c:96:23: warning: no previous prototype for 'get_connector' [-Wmissing-prototypes]
drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c:84:5: warning: no previous prototype for 'mdp4_plane_set_property' [-Wmissing-prototypes]

In fact, these functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
So this patch marks these functions with 'static'.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Reviewed-by: Archit Taneja <architt@codeaurora.org>
Signed-off-by: Rob Clark <robdclark@gmail.com>
drivers/gpu/drm/msm/mdp/mdp4/mdp4_lcdc_encoder.c
drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c

index bc3d8e7..a06b064 100644 (file)
@@ -93,7 +93,7 @@ static const struct drm_encoder_funcs mdp4_lcdc_encoder_funcs = {
 };
 
 /* this should probably be a helper: */
-struct drm_connector *get_connector(struct drm_encoder *encoder)
+static struct drm_connector *get_connector(struct drm_encoder *encoder)
 {
        struct drm_device *dev = encoder->dev;
        struct drm_connector *connector;
index 7c9626d..3903dbc 100644 (file)
@@ -81,7 +81,7 @@ static void mdp4_plane_install_properties(struct drm_plane *plane,
        // XXX
 }
 
-int mdp4_plane_set_property(struct drm_plane *plane,
+static int mdp4_plane_set_property(struct drm_plane *plane,
                struct drm_property *property, uint64_t val)
 {
        // XXX