OSDN Git Service

[SCSI] scsi_debug: fix endianness bug in sdebug_build_parts()
authorAkinobu Mita <akinobu.mita@gmail.com>
Mon, 26 Aug 2013 13:08:40 +0000 (22:08 +0900)
committerJames Bottomley <JBottomley@Parallels.com>
Tue, 3 Sep 2013 14:28:08 +0000 (07:28 -0700)
With module parameter num_parts > 0, partition table is built on the
ramdisk storage when loading the driver.  Unfortunately, there is an
endianness bug in sdebug_build_parts().  So the partition table is not
correctly initialized on big-endian systems.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Tested-by: Martin Peschke <mpeschke@linux.vnet.ibm.com>
Acked-by: Douglas Gilbert <dgilbert@interlog.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/scsi_debug.c

index cb4fefa..2f39b13 100644 (file)
@@ -2659,8 +2659,8 @@ static void __init sdebug_build_parts(unsigned char *ramp,
                               / sdebug_sectors_per;
                pp->end_sector = (end_sec % sdebug_sectors_per) + 1;
 
-               pp->start_sect = start_sec;
-               pp->nr_sects = end_sec - start_sec + 1;
+               pp->start_sect = cpu_to_le32(start_sec);
+               pp->nr_sects = cpu_to_le32(end_sec - start_sec + 1);
                pp->sys_ind = 0x83;     /* plain Linux partition */
        }
 }