OSDN Git Service

replace switch with if statement in QRasterPaintEngine::init()
authorIvailo Monev <xakepa10@gmail.com>
Sun, 26 Jul 2020 20:11:49 +0000 (20:11 +0000)
committerIvailo Monev <xakepa10@gmail.com>
Sun, 26 Jul 2020 20:11:49 +0000 (20:11 +0000)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
src/gui/painting/qpaintengine_raster.cpp

index 5f47a5f..136905f 100644 (file)
@@ -233,21 +233,13 @@ void QRasterPaintEngine::init()
     d->mono_surface = false;
     gccaps &= ~PorterDuff;
 
-    QImage::Format format = QImage::Format_Invalid;
-
-    switch (d->device->devType()) {
-    case QInternal::Pixmap:
-        qWarning("QRasterPaintEngine: unsupported for pixmaps...");
-        break;
-    case QInternal::Image:
-        format = d->rasterBuffer->prepare(static_cast<QImage *>(d->device));
-        break;
-    default:
+    if (Q_UNLIKELY(d->device->devType() != QInternal::Image)) {
         qWarning("QRasterPaintEngine: unsupported target device %d\n", d->device->devType());
         d->device = 0;
         return;
     }
 
+    QImage::Format format = d->rasterBuffer->prepare(static_cast<QImage *>(d->device));
     switch (format) {
     case QImage::Format_MonoLSB:
     case QImage::Format_Mono: