OSDN Git Service

media: v4l2-ctls-core.c: kvmalloc_array -> kvcalloc
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Mon, 2 May 2022 07:15:47 +0000 (09:15 +0200)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 13 May 2022 09:02:22 +0000 (11:02 +0200)
Fixes smatch warning:

drivers/media/v4l2-core/v4l2-ctrls-core.c:1143 v4l2_ctrl_handler_init_class() warn: Please consider using kvcalloc instead

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/v4l2-core/v4l2-ctrls-core.c

index 8968cec..949c188 100644 (file)
@@ -1140,9 +1140,8 @@ int v4l2_ctrl_handler_init_class(struct v4l2_ctrl_handler *hdl,
        INIT_LIST_HEAD(&hdl->ctrls);
        INIT_LIST_HEAD(&hdl->ctrl_refs);
        hdl->nr_of_buckets = 1 + nr_of_controls_hint / 8;
-       hdl->buckets = kvmalloc_array(hdl->nr_of_buckets,
-                                     sizeof(hdl->buckets[0]),
-                                     GFP_KERNEL | __GFP_ZERO);
+       hdl->buckets = kvcalloc(hdl->nr_of_buckets, sizeof(hdl->buckets[0]),
+                               GFP_KERNEL);
        hdl->error = hdl->buckets ? 0 : -ENOMEM;
        v4l2_ctrl_handler_init_request(hdl);
        return hdl->error;