OSDN Git Service

bnxt_en: check return value of bnxt_hwrm_func_resc_qcaps
authorScott Branden <scott.branden@broadcom.com>
Mon, 22 Mar 2021 07:08:42 +0000 (03:08 -0400)
committerDavid S. Miller <davem@davemloft.net>
Mon, 22 Mar 2021 20:07:28 +0000 (13:07 -0700)
Check return value of call to bnxt_hwrm_func_resc_qcaps in
bnxt_hwrm_if_change and return failure on error.

Reviewed-by: Edwin Peer <edwin.peer@broadcom.com>
Signed-off-by: Scott Branden <scott.branden@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnxt/bnxt.c

index 3624e79..7f40dd7 100644 (file)
@@ -9634,6 +9634,9 @@ static int bnxt_hwrm_if_change(struct bnxt *bp, bool up)
                        struct bnxt_hw_resc *hw_resc = &bp->hw_resc;
 
                        rc = bnxt_hwrm_func_resc_qcaps(bp, true);
+                       if (rc)
+                               netdev_err(bp->dev, "resc_qcaps failed\n");
+
                        hw_resc->resv_cp_rings = 0;
                        hw_resc->resv_stat_ctxs = 0;
                        hw_resc->resv_irqs = 0;
@@ -9647,7 +9650,7 @@ static int bnxt_hwrm_if_change(struct bnxt *bp, bool up)
                        }
                }
        }
-       return 0;
+       return rc;
 }
 
 static int bnxt_hwrm_port_led_qcaps(struct bnxt *bp)