OSDN Git Service

staging: lustre: llite: initialize xattr->xe_namelen
authorJames Simmons <jsimmons@infradead.org>
Mon, 16 Apr 2018 04:14:50 +0000 (00:14 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 23 Apr 2018 12:57:40 +0000 (14:57 +0200)
When the allocation of xattr->xe_name was moved to kstrdup()
setting xattr->xe_namelen was dropped. This field is used
in several parts of the xattr cache code so it broke xattr
handling. Initialize xattr->xe_namelen when allocating
xattr->xe_name succeeds. Also change the debugging statement
to really report the xattr name instead of its length which
wasn't event being set.

Fixes: b3dd8957c23a ("staging: lustre: lustre: llite: Use kstrdup"
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lustre/llite/xattr_cache.c

index 4dc799d..ef66949 100644 (file)
@@ -121,10 +121,12 @@ static int ll_xattr_cache_add(struct list_head *cache,
 
        xattr->xe_name = kstrdup(xattr_name, GFP_NOFS);
        if (!xattr->xe_name) {
-               CDEBUG(D_CACHE, "failed to alloc xattr name %u\n",
-                      xattr->xe_namelen);
+               CDEBUG(D_CACHE, "failed to alloc xattr name %s\n",
+                      xattr_name);
                goto err_name;
        }
+       xattr->xe_namelen = strlen(xattr_name) + 1;
+
        xattr->xe_value = kmemdup(xattr_val, xattr_val_len, GFP_NOFS);
        if (!xattr->xe_value)
                goto err_value;