OSDN Git Service

scripts/find-unused-docs: Fix massive false positives
authorGeert Uytterhoeven <geert+renesas@glider.be>
Mon, 27 Jan 2020 09:31:07 +0000 (10:31 +0100)
committerJonathan Corbet <corbet@lwn.net>
Mon, 27 Jan 2020 21:25:06 +0000 (14:25 -0700)
scripts/find-unused-docs.sh invokes scripts/kernel-doc to find out if a
source file contains kerneldoc or not.

However, as it passes the no longer supported "-text" option to
scripts/kernel-doc, the latter prints out its help text, causing all
files to be considered containing kerneldoc.

Get rid of these false positives by removing the no longer supported
"-text" option from the scripts/kernel-doc invocation.

Cc: stable@vger.kernel.org # 4.16+
Fixes: b05142675310d2ac ("scripts: kernel-doc: get rid of unused output formats")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20200127093107.26401-1-geert+renesas@glider.be
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
scripts/find-unused-docs.sh

index 3f46f89..ee6a50e 100755 (executable)
@@ -54,7 +54,7 @@ for file in `find $1 -name '*.c'`; do
        if [[ ${FILES_INCLUDED[$file]+_} ]]; then
        continue;
        fi
-       str=$(scripts/kernel-doc -text -export "$file" 2>/dev/null)
+       str=$(scripts/kernel-doc -export "$file" 2>/dev/null)
        if [[ -n "$str" ]]; then
        echo "$file"
        fi