OSDN Git Service

net: phy: replace if-else statements with switch
authorWeihang Li <liweihang@huawei.com>
Wed, 16 Jun 2021 10:01:26 +0000 (18:01 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 16 Jun 2021 19:34:07 +0000 (12:34 -0700)
Switch statement is clearer than a group of 'if-else'.

Signed-off-by: Weihang Li <liweihang@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/marvell.c

index 23751d9..3de93c9 100644 (file)
@@ -809,14 +809,19 @@ static int m88e1111_config_init_rgmii_delays(struct phy_device *phydev)
 {
        int delay;
 
-       if (phydev->interface == PHY_INTERFACE_MODE_RGMII_ID) {
+       switch (phydev->interface) {
+       case PHY_INTERFACE_MODE_RGMII_ID:
                delay = MII_M1111_RGMII_RX_DELAY | MII_M1111_RGMII_TX_DELAY;
-       } else if (phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID) {
+               break;
+       case PHY_INTERFACE_MODE_RGMII_RXID:
                delay = MII_M1111_RGMII_RX_DELAY;
-       } else if (phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID) {
+               break;
+       case PHY_INTERFACE_MODE_RGMII_TXID:
                delay = MII_M1111_RGMII_TX_DELAY;
-       } else {
+               break;
+       default:
                delay = 0;
+               break;
        }
 
        return phy_modify(phydev, MII_M1111_PHY_EXT_CR,