OSDN Git Service

hwmon: abituguru: make array probe_order static, makes object smaller
authorColin Ian King <colin.king@canonical.com>
Sun, 6 Oct 2019 14:52:31 +0000 (15:52 +0100)
committerGuenter Roeck <linux@roeck-us.net>
Wed, 6 Nov 2019 22:37:19 +0000 (14:37 -0800)
Don't populate the array probe_order on the stack but instead make it
static. Makes the object code smaller by 94 bytes.

Before:
   text    data     bss     dec     hex filename
  41473   13448     320   55241    d7c9 drivers/hwmon/abituguru.o

After:
   text    data     bss     dec     hex filename
  41315   13512     320   55147    d76b drivers/hwmon/abituguru.o

(gcc version 9.2.1, amd64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20191006145231.24022-1-colin.king@canonical.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/abituguru.c

index a5cf6b2..681f062 100644 (file)
@@ -1264,7 +1264,7 @@ static int abituguru_probe(struct platform_device *pdev)
         * El weirdo probe order, to keep the sysfs order identical to the
         * BIOS and window-appliction listing order.
         */
-       const u8 probe_order[ABIT_UGURU_MAX_BANK1_SENSORS] = {
+       static const u8 probe_order[ABIT_UGURU_MAX_BANK1_SENSORS] = {
                0x00, 0x01, 0x03, 0x04, 0x0A, 0x08, 0x0E, 0x02,
                0x09, 0x06, 0x05, 0x0B, 0x0F, 0x0D, 0x07, 0x0C };