OSDN Git Service

HID: intel-ish-hid: fix wrong error handling in ishtp_cl_alloc_tx_ring()
authorZhang Lixu <lixu.zhang@intel.com>
Wed, 16 Oct 2019 00:15:59 +0000 (08:15 +0800)
committerJiri Kosina <jkosina@suse.cz>
Wed, 16 Oct 2019 06:26:55 +0000 (08:26 +0200)
When allocating tx ring buffers failed, should free tx buffers, not rx buffers.

Signed-off-by: Zhang Lixu <lixu.zhang@intel.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/intel-ish-hid/ishtp/client-buffers.c

index 1b0a0cc..513d7a4 100644 (file)
@@ -84,7 +84,7 @@ int ishtp_cl_alloc_tx_ring(struct ishtp_cl *cl)
        return  0;
 out:
        dev_err(&cl->device->dev, "error in allocating Tx pool\n");
-       ishtp_cl_free_rx_ring(cl);
+       ishtp_cl_free_tx_ring(cl);
        return  -ENOMEM;
 }